Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Story] Indicate voluntary reporter status #1000

Merged
merged 19 commits into from
Oct 29, 2024
Merged

[Story] Indicate voluntary reporter status #1000

merged 19 commits into from
Oct 29, 2024

Conversation

tanner-ricks
Copy link
Contributor

@tanner-ricks tanner-ricks commented Oct 15, 2024 •
edited
Loading

Added frontend support for Voluntary Filing Status and renamed some page elements.

Changes

  • Added a Radio Button Group component to handle the state stuff of the radio buttons.
  • Added the Indicate Voluntary Reporter Status section and Radio buttons to the Point of Contact Page
  • Added Zod validation for the voluntary reporter status
  • Fixed a bug which caused the extension field to no longer be optional and fixed a test related to it
  • Updated verbiage from Point of Contact to Filing Details where appropriate
  • Updated other verbiage to be in line with the Figma docs
  • Moved and updated the Voluntary Reporter status section in the Sign and Submit page
  • Updated tests to use new verbiage where appropriate and fix test failures

How to test this PR

  1. Read the notes
  2. Pull the branch
  3. Restart any stack components as necessary
  4. Access the site
  5. Fill out a submission until you can navigate to the 'Provide Filing Details' page
  6. Verify that everything appears as expected.
  7. Without filing anything out, attempt to submit the form
  8. Verify that the appropriate errors appear for the Voluntary Reporter Status being blank
  9. Fill out the form
  10. Click 'Continue to next step'
  11. Verify that the sign and submit page contains the Voluntary Reporter Status section in the right place and that it appears correct.

Screenshots

Screenshot 2024-10-24 at 12 57 23 PM Screenshot 2024-10-24 at 12 57 46 PM Screenshot 2024-10-24 at 12 57 02 PM Screenshot 2024-10-24 at 12 57 13 PM Screenshot 2024-10-24 at 12 59 42 PM Screenshot 2024-10-24 at 1 00 22 PM Screenshot 2024-10-24 at 12 58 04 PM

Notes

  • There may be e2e test failures at the moment. I am putting off completely fixing/extending them until the follow on work
  • Would like to rename all appropriate instances of PointOfContact to FilingDetails as a part of the follow on work as well.

@tanner-ricks tanner-ricks linked an issue Oct 15, 2024 that may be closed by this pull request
[Page] [Point of Contact] --> [Provide Filing Details], Implement Voluntary Reporter Status in Frontend #991
Closed
@tanner-ricks tanner-ricks marked this pull request as ready for review October 16, 2024 18:44
@tanner-ricks tanner-ricks changed the title DRAFT: [Story] Indicate voluntary reporter status [Story] Indicate voluntary reporter status Oct 16, 2024
natalia-fitzgerald
natalia-fitzgerald requested changes Oct 28, 2024
View reviewed changes
Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanner-ricks
Nice work! I think we're close. Just a couple of quick adjustments.

Provide filing details

  • On dev pub this space is showing up as 60px. It should be 45px.
Dev Pub Figma
Screenshot 2024-10-28 at 12 01 51 PM Screenshot 2024-10-28 at 12 15 32 PM
  • On dev pub this space is showing up as 45px. It should be 60px.
Dev Pub Figma
Screenshot 2024-10-28 at 12 03 59 PM Screenshot 2024-10-28 at 12 17 27 PM
  • We decided to revert to the original approach to the privacy notice (shown here). At a later date we will push for a change but this will have to go through review from outside of our team. Can we update what we have on dev pub to reflect this?
Dev Pub Figma
Screenshot 2024-10-28 at 12 21 46 PM Screenshot 2024-10-28 at 12 17 27 PM

@billhimmelsbach
Will this issue be handled as a separate PR? Yes.

  • Screenshot 2024-10-28 at 12 19 17 PM

Sign and submit

  • The spacing here should be 60px. It is showing up as 45px on Dev pub.
Dev Pub Figma
Screenshot 2024-10-28 at 12 34 01 PM Screenshot 2024-10-28 at 12 32 27 PM

@billhimmelsbach

  • This may belong in the review for Sign and submit that I believe you're working on now...but this space should be 45px instead of 60px.
Dev Pub Figma
Screenshot 2024-10-28 at 12 42 32 PM Screenshot 2024-10-28 at 12 41 37 PM

@billhimmelsbach
Copy link
Contributor

billhimmelsbach commented Oct 28, 2024 •
edited
Loading

Hi @natalia-fitzgerald @tanner-ricks! Thanks for the review @natalia-fitzgerald, the spacing for voluntary reporter status on the filing details and sign and submit page can be included, but I would exclude...

The privacy notice changes aren't part of this PR

We decided to revert to the original approach to the privacy notice (shown here)

The state highlight box changes aren't part of this PR

Will this issue be handled as a separate PR?

The sign and submit alert box spacing stuff aren't part of this PR

This may belong in the review for Sign and submit

So just a few minor spacing adjustments for the voluntary filing status, and then we're good to go. 👍

@natalia-fitzgerald natalia-fitzgerald mentioned this pull request Oct 28, 2024
Closed
natalia-fitzgerald
natalia-fitzgerald approved these changes Oct 28, 2024
View reviewed changes
Copy link

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanner-ricks
I checked the following and these items look good and are approved.

Provide filing details

  • Change the margin between the alert and the first section to 45px.
  • Change the margin between the sections to 60px. Space between H2 sections should always be 60px (specifically between Indicate voluntary reporter status and Provide point of contact)
  • Revert to previous approach to Privacy notice

Sign and submit

  • Change the margin between the sections to 60px (specifically between Confirm your register information and Confirm voluntary reporter status)

@natalia-fitzgerald
Copy link

@billhimmelsbach
Remaining work to be done (separate PRs) -- after we merge this PR:

  • Single select styling
Screenshot 2024-10-28 at 12 19 17 PM

@billhimmelsbach

  • This margin should be 45px instead of 60px.
Dev Pub Figma
Screenshot 2024-10-28 at 12 42 32 PM Screenshot 2024-10-28 at 12 41 37 PM

@billhimmelsbach
Copy link
Contributor

Sounds good, I'll pick those up @natalia-fitzgerald

@tanner-ricks tanner-ricks merged commit ce7802d into main Oct 29, 2024
4 checks passed
@tanner-ricks tanner-ricks deleted the 243-voluntary-reporter-status branch October 29, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shindigira shindigira shindigira left review comments

@natalia-fitzgerald natalia-fitzgerald natalia-fitzgerald approved these changes

@billhimmelsbach billhimmelsbach Awaiting requested review from billhimmelsbach billhimmelsbach is a code owner

@meissadia meissadia Awaiting requested review from meissadia meissadia is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Page] [Point of Contact] --> [Provide Filing Details], Implement Voluntary Reporter Status in Frontend
4 participants
@tanner-ricks @billhimmelsbach @natalia-fitzgerald @shindigira